[Test] Complete test for Aggregated Shamir's Secret Sharing Scheme and DKG protocol. #8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
random-zebra
approved these changes
Jul 19, 2021
There was a problem hiding this comment.
Really nice test coverage. ACK 9b5a07f
There's few minor nits fixed in random-zebra@0fa37a4. Can be picked here, or addressed in another pull request.
|
Made most of them a bit differently (realized late that you did them in your commit). As said in one of the comments, i didn't remove the sigs vector and use it to verify the recovered SIGa(0) result at the end. Side from that, cherry-picked the last check for a failed verification against the aggregated threshold signature and gave you authorship for it 👍. And.. only TODO that have left is the protocol naming standardizations that we spoke via pm. Will add them later today. |
|
done, updated. We can move forward with this now. |
…d threshold signature when one of the signature shares is corrupted/invalid. And refactor and simplify Pa(x) and SIG(0) computation.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Going one step further over the Threshold Signatures tests, validating that the correlation and aggregation BLS properties are working properly on top of the Shamir's Secret Sharing Scheme, verifying the DKG protocol and each participant share/sig validation step described in DIP6 BLS M-of-N Threshold Scheme and Distributed Key Generation
Plus corrected a duplicated
HexStrfunction and few invalid function's args names.