Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Documentation references RFC 7049, which has been replaced by RFC 8949 (STD94). #269

Closed
cabo opened this issue Jan 20, 2023 · 0 comments · Fixed by #275
Closed

Documentation references RFC 7049, which has been replaced by RFC 8949 (STD94). #269

cabo opened this issue Jan 20, 2023 · 0 comments · Fixed by #275
Assignees
@PJK
Labels
bug

Comments

@cabo
Copy link

cabo commented Jan 20, 2023

Describe the bug
Documentation references RFC 7049, which has been replaced by RFC 8949 (STD94) a couple of years ago.

To Reproduce
(Read the documentation.)

Expected behavior
Update the documentation to use RFC 8949.
In the process, check that clarifications made in RFC 8949 actually are addressed (e.g., deterministic encoding) — https://www.rfc-editor.org/rfc/rfc8949#name-changes-from-rfc-7049 might help here.

Environment
"Documentation for version 0.10.1, updated on Jan 08, 2023."
@cabo cabo added the bug label Jan 20, 2023
@cabo cabo assigned PJK Jan 20, 2023
@PJK PJK mentioned this issue Feb 17, 2023
Merged
@PJK PJK closed this as completed in #275 Feb 17, 2023
netbsd-srcmastr pushed a commit to NetBSD/pkgsrc that referenced this issue Feb 4, 2024
libcbor: updated to 0.11.0
ebc93d4 
0.11.0 (2024-02-04)
---------------------
- [Updated documentation to refer to RFC 8949](PJK/libcbor#269)
- Improvements to `cbor_describe`
  - [Bytestring data will now be printed as well](PJK/libcbor#281) by  [akallabeth](https://github.com/akallabeth)
  - [Formatting consistency and clarity improvements](PJK/libcbor#285)
- [Fix `cbor_string_set_handle` not setting the codepoint count](PJK/libcbor#286)
- BREAKING: [`cbor_load` will no longer fail on input strings that are well-formed but not valid UTF-8](PJK/libcbor#286)
  - If you were relying on the validation, please check the result using `cbor_string_codepoint_count` instead
- BREAKING: [All decoders like `cbor_load` and `cbor_stream_decode` will accept all well-formed tag values](PJK/libcbor#308) (bug discovered by [dskern-github](https://github.com/dskern-github))
  - Previously, decoding of certain values would fail with `CBOR_ERR_MALFORMATED` or `CBOR_DECODER_ERROR`
  - This also makes decoding symmetrical with serialization, which already accepts all values
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@PJK PJK

Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Update docs for STD94 PJK/libcbor
2 participants
@cabo @PJK