-
Notifications
You must be signed in to change notification settings - Fork 97
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rework memory allocation failure handling in bytestring builders, add tests #242
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #242 +/- ##
==========================================
+ Coverage 95.85% 96.49% +0.64%
==========================================
Files 20 20
Lines 1544 1541 -3
==========================================
+ Hits 1480 1487 +7
+ Misses 64 54 -10 ☔ View full report in Codecov by Sentry. |
PJK
force-pushed
the
builder-callback-bytestring
branch
from
December 27, 2022 18:03
23c2d7c
to
b7c04c2
Compare
cc @James-ZHANG |
9 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The decoder should clean up intermediate items when the callback fails. The rest of the cleanup is handled by the decoder stack unwinding
Replaces #228. In retrospect, the fix wasn't a good solution: the new behavior did fix the memory leak in the streaming decoder, but the semantics didn't make sense for standalone usage of
cbor_bytestring_add_chunk
and were also inconsistent withcbor_array_push
.Fixes #231
Checklist