Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add [[nodiscard]]-like macro and fix a few violations #248

Merged
merged 8 commits into from
Dec 27, 2022
Merged

Conversation

PJK
Copy link
Owner

@PJK PJK commented Dec 27, 2022

Description

First step towards #247

Marking all functions where ignoring the return value

  • is dangerous, or
  • doesn't make sense since the function has no other effect (indicates incorrect usage)

Checklist

  • I have read followed CONTRIBUTING.md
    • I have added tests
    • I have updated the documentation
    • I have updated the CHANGELOG
  • Are there any breaking changes?
    • If yes: I have marked them in the CHANGELOG (example)
  • Does this PR introduce any platform specific code?
  • Security: Does this PR potentially affect security?
  • Performance: Does this PR potentially affect performance?

@codecov-commenter
Copy link

codecov-commenter commented Dec 27, 2022

Codecov Report

Merging #248 (f63418f) into master (c5e5731) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #248   +/-   ##
=======================================
  Coverage   97.26%   97.26%           
=======================================
  Files          20       20           
  Lines        1537     1537           
=======================================
  Hits         1495     1495           
  Misses         42       42           
Impacted Files Coverage Δ
src/cbor.c 99.44% <ø> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@PJK PJK merged commit 8aecf10 into master Dec 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants