Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix cbor_serialized_size for zero-len strings #260

Merged
merged 3 commits into from
Dec 30, 2022
Merged

Fix cbor_serialized_size for zero-len strings #260

merged 3 commits into from
Dec 30, 2022

Conversation

PJK
Copy link
Owner

@PJK PJK commented Dec 30, 2022

Fixes #259

Huge thanks for @martelletto for quickly reporting this!

Minor release will follow to patch v0.10

@codecov-commenter
Copy link

Codecov Report

Merging #260 (2393275) into master (d9e3d17) will increase coverage by 0.12%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master     #260      +/-   ##
==========================================
+ Coverage   99.57%   99.69%   +0.12%     
==========================================
  Files          20       20              
  Lines        1651     1655       +4     
==========================================
+ Hits         1644     1650       +6     
+ Misses          7        5       -2     
Impacted Files Coverage Δ
src/cbor/serialization.c 100.00% <100.00%> (ø)
src/cbor/streaming.c 100.00% <0.00%> (+0.99%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@PJK PJK merged commit cbea271 into master Dec 30, 2022
@PJK PJK mentioned this pull request Dec 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Broken encoding of empty byte strings in 0.10.0
2 participants