Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Selecting all the notes in a bookmark/timing change #59

Merged
merged 6 commits into from
Jul 29, 2023

Conversation

Brollyy
Copy link
Collaborator

@Brollyy Brollyy commented Jul 19, 2023

#57 Implemented selection toggle of all the notes in specific bookmark/timing change on Ctrl+LeftClick.

To streamline certain operations, refactored MapDifficulty to store all notes, bookmarks and timing changes as SortedSet instead of List.

Implemented more frequent updates to the Discord Presence to better reflect the current status of user.

…ming change on Ctrl+LeftClick.

To streamline certain operations, refactored MapDifficulty to store all notes, bookmarks and timing changes as SortedSet instead of List.

Implemented more frequent updates to the Discord Presence to better reflect the current status of user.
@Brollyy Brollyy added the enhancement New feature or request label Jul 19, 2023
@Brollyy Brollyy added this to the 1.2.2 milestone Jul 19, 2023
@Brollyy Brollyy requested a review from PKBeam July 19, 2023 23:30
@Brollyy Brollyy linked an issue Jul 19, 2023 that may be closed by this pull request
Classes/MapEditor/MapEditor.cs Show resolved Hide resolved
Classes/MapEditor/MapEditor.cs Outdated Show resolved Hide resolved
Classes/MapEditor/MapEditor.cs Outdated Show resolved Hide resolved
Classes/MapEditor/MapEditor.cs Outdated Show resolved Hide resolved
Classes/MapEditor/MapEditor.cs Outdated Show resolved Hide resolved
Classes/MapEditor/MapEditor.cs Outdated Show resolved Hide resolved
Classes/MapEditor/MapEditor.cs Outdated Show resolved Hide resolved
Classes/UI/EditorGridController.cs Outdated Show resolved Hide resolved
Classes/UI/EditorGridController.cs Outdated Show resolved Hide resolved
@Brollyy Brollyy marked this pull request as draft July 19, 2023 23:44
…ances on note operations.

Fixed an issue with selected notes not being properly hightlighted after editor grid was redrawn, e.g. after removing a bookmark.

Fixed an issue with dragging from right to left not selecting any notes after the changes.
@Brollyy Brollyy marked this pull request as ready for review July 20, 2023 22:28
Copy link
Contributor

@Nytilde Nytilde left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've tested your changes and must say that they are a great improvement!

Classes/MapEditor/MapEditor.cs Outdated Show resolved Hide resolved
Classes/MapEditor/Bookmark.cs Outdated Show resolved Hide resolved
Classes/MapEditor/MapEditor.cs Show resolved Hide resolved
…ixed some remaining issues with Discord Presence not updating correctly with changes in the application.
@Brollyy Brollyy requested a review from PKBeam July 24, 2023 16:00
@Brollyy Brollyy merged commit 2e7c9f0 into master Jul 29, 2023
@Brollyy Brollyy deleted the 57-selecting-all-the-notes-in-a-bookmarktiming-change branch July 29, 2023 12:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Selecting all the notes in a bookmark/timing change
3 participants