Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add specific reasons for failed task submission #375

Merged
merged 11 commits into from
Feb 27, 2025
Merged

Add specific reasons for failed task submission #375

merged 11 commits into from
Feb 27, 2025

Conversation

1daidai1
Copy link
Collaborator

@1daidai1 1daidai1 commented Nov 26, 2024 •
edited
Loading

image
image
本地适配门禁已过：
08a837a03ffcfbf613c156d6034fa67
门禁适配新已过-2025/02/26
79ebe9a9c4df4357b76fe8f5048607f

@RileyWen
Copy link
Collaborator

这块之前特意就写的不用string了 一边在errcode化 怎么这边还开始返祖了

@1daidai1
Copy link
Collaborator Author

如果不想这么改的话那我多增加几个枚举值吧，将参数错误这个枚举细化多几个枚举值

@PKUHPC PKUHPC deleted a comment from 1daidai1 Dec 1, 2024
@1daidai1 1daidai1 force-pushed the dev/addsubmitreason branch from b65d967 to 1970f99 Compare December 2, 2024 03:17
@1daidai1 1daidai1 mentioned this pull request Dec 2, 2024
Closed
@1daidai1 1daidai1 force-pushed the dev/addsubmitreason branch 3 times, most recently from b382e40 to 2d88fb3 Compare December 10, 2024 08:33
@1daidai1
Copy link
Collaborator Author

前端：PKUHPC/CraneSched-FrontEnd#218

@1daidai1 1daidai1 mentioned this pull request Dec 10, 2024
Merged
@1daidai1 1daidai1 force-pushed the dev/addsubmitreason branch from 1e858c5 to 52eedd7 Compare December 10, 2024 08:53
@Nativu5
Copy link
Collaborator

Nativu5 commented Dec 11, 2024

先基于 Master 分支 rebase 一下吧。

@1daidai1 1daidai1 force-pushed the dev/addsubmitreason branch from 52eedd7 to bf52d55 Compare December 11, 2024 09:44
@1daidai1 1daidai1 force-pushed the dev/addsubmitreason branch 2 times, most recently from 1c01ff4 to 5358681 Compare December 16, 2024 02:33
@1daidai1
Copy link
Collaborator Author

代码已提交

L-Xiafeng
L-Xiafeng reviewed Feb 16, 2025
View reviewed changes
Copy link
Collaborator

@L-Xiafeng L-Xiafeng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

原来的Reason是给用户直接看的，现在改成日志之后都修改一下

@L-Xiafeng L-Xiafeng added the enhancement New feature or request label Feb 16, 2025
@1daidai1 1daidai1 force-pushed the dev/addsubmitreason branch 2 times, most recently from dee5218 to 8eae9d4 Compare February 17, 2025 06:40
@huerni huerni mentioned this pull request Feb 18, 2025
Merged
L-Xiafeng
L-Xiafeng requested changes Feb 20, 2025
View reviewed changes
Copy link
Collaborator

@L-Xiafeng L-Xiafeng left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

上面提到的所有日志都改一下

  1. 信息不够，看不出来在说什么
  2. 这些都是原来给用户的报错信息，不适合直接改成日志信息

@1daidai1 1daidai1 force-pushed the dev/addsubmitreason branch 2 times, most recently from e9fa4fb to 430f9d4 Compare February 21, 2025 06:42
@1daidai1 1daidai1 force-pushed the dev/addsubmitreason branch from 24f4f2f to b53da8d Compare February 21, 2025 08:18
@RileyWen RileyWen force-pushed the dev/addsubmitreason branch from b53da8d to 29d1fb6 Compare February 22, 2025 14:13
RileyWen
RileyWen reviewed Feb 22, 2025
View reviewed changes
RileyWen
RileyWen reviewed Feb 22, 2025
View reviewed changes
RileyWen
RileyWen reviewed Feb 22, 2025
View reviewed changes
RileyWen
RileyWen reviewed Feb 22, 2025
View reviewed changes
RileyWen
RileyWen reviewed Feb 22, 2025
View reviewed changes
RileyWen
RileyWen reviewed Feb 22, 2025
View reviewed changes
RileyWen
RileyWen reviewed Feb 22, 2025
View reviewed changes
RileyWen
RileyWen reviewed Feb 22, 2025
View reviewed changes
RileyWen
RileyWen reviewed Feb 22, 2025
View reviewed changes
RileyWen
RileyWen reviewed Feb 22, 2025
View reviewed changes
@1daidai1 1daidai1 force-pushed the dev/addsubmitreason branch from 6aaf763 to 4f5bd93 Compare February 25, 2025 08:57
L-Xiafeng
L-Xiafeng reviewed Feb 27, 2025
View reviewed changes
Copy link
Collaborator

@L-Xiafeng L-Xiafeng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

其他没问题了

@L-Xiafeng
style: Change CraneErrCode::__ERR_CODE_COUNT
0f7a365 
Signed-off-by: Li Junlin <xiafeng.li@foxmail.com>
@Nativu5 Nativu5 merged commit 806974e into master Feb 27, 2025
1 check failed
@Nativu5 Nativu5 deleted the dev/addsubmitreason branch February 27, 2025 14:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RileyWen RileyWen RileyWen left review comments

@huerni huerni huerni left review comments

@Nativu5 Nativu5 Nativu5 approved these changes

@L-Xiafeng L-Xiafeng L-Xiafeng approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@1daidai1 @RileyWen @Nativu5 @huerni @L-Xiafeng