feat: Course home heading navigation #2
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Temporary PR, after review the code will be moved to frontend-build |
PKulkoRaccoonGang
changed the title
PKulkoRaccoonGang
force-pushed
the
Peter_Kulko/course-outline-headings
branch
from
ebe88de
to
99b71c5
Compare
ihor-romaniuk
approved these changes
Oct 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request focuses on improving accessibility within the
Sectioncomponent in thesrc/course-home/outline-tab/Section.jsxfile. The changes ensure better keyboard navigation and focus management.Accessibility improvements:
tabIndexfrom elements inside theCollapsiblecomponent to fix the focus logic, ensuring better accessibility by not interfering with the default focus order. (src/course-home/outline-tab/Section.jsx)tabIndex="0"to theh2element to make it focusable, improving keyboard navigation. (src/course-home/outline-tab/Section.jsx)tabIndex="-1"to theIconButtoncomponents to prevent them from being focusable, streamlining the focus order. (src/course-home/outline-tab/Section.jsx)