Change SET references to SET0 #3
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Now that we introduced the PROPERTY language feature in the compiler, SET will be identified as a reserved keyword. Hence, using set as a variable name will result in compiler errors.
mhasel
reviewed
Feb 10, 2025
| @@ -530,7 +530,7 @@ VAR_INPUT (* CONSTANT *) | |||
| Timeout : TIME; | |||
| END_VAR | |||
| VAR_INPUT | |||
| SET : BOOL; | |||
| SET0 : BOOL; | |||
There was a problem hiding this comment.
This is a breaking change and should be documented as such in the readme.
Additionally, SET is not a keyword in CodeSys and we should allow it in identifiers, but that probably requires quite a few changes and we can come back to it later
There was a problem hiding this comment.
Thanks, good catch! I'll merge this and revert these changes once we fixed it on the compiler side as discussed yesterday. Here's the relevant issue PLC-lang/rusty#1408 to keep track of it
There was a problem hiding this comment.
We still need to update the list of breaking changes in the readme (in this repo, not in RuSTy)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now that we introduced the PROPERTY language feature in the compiler, SET will be identified as a reserved keyword. Hence, using set as a variable name will result in compiler errors.