Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add decoding to section mangler #1205

Merged
merged 8 commits into from
Jun 13, 2024

Conversation

CohenArthur
Copy link
Contributor

@CohenArthur CohenArthur commented Apr 18, 2024

Needs #1198 and #1199, so only review section_mangler/parser.rs and section_mangler/lib.rs

This PR adds the reverse operation to #1160 and #1198, by parsing the mangled section name and deserializing it into an instance of SectionMangler. This allows the loader to compare two mangled section names easily, and to make certain decisions.

ghaith
ghaith previously approved these changes Jun 3, 2024
@ghaith
Copy link
Collaborator

ghaith commented Jun 12, 2024

I think the conflict is just in tests, i'll fix the conflict and merge this
Edit: I can't push to the fork, I think you it's a setting on the PR from your side to allow us to push the fork branch.
@CohenArthur do you mind solving the conflics? It's just a cargo insta accept I'll approve and push right away.

@CohenArthur
Copy link
Contributor Author

@ghaith no worries, I'll update this PR with fixed conflicts as soon as the previous two are accepted. in the future PRs should be smaller but these were all depending on each other so it was a bit of a mess :) sorry!

ghaith
ghaith previously approved these changes Jun 13, 2024
@CohenArthur CohenArthur dismissed ghaith’s stale review June 13, 2024 11:13

The merge-base changed after approval.

ghaith
ghaith previously approved these changes Jun 13, 2024
@CohenArthur CohenArthur dismissed ghaith’s stale review June 13, 2024 11:18

The merge-base changed after approval.

ghaith
ghaith previously approved these changes Jun 13, 2024
@ghaith
Copy link
Collaborator

ghaith commented Jun 13, 2024

Github does not seem to accept me as reviewer
image
I'm not sure why that is but i'll check the settings and try again

@CohenArthur CohenArthur dismissed ghaith’s stale review June 13, 2024 11:23

The merge-base changed after approval.

@ghaith ghaith self-requested a review June 13, 2024 11:24
ghaith
ghaith previously approved these changes Jun 13, 2024
@CohenArthur CohenArthur dismissed ghaith’s stale review June 13, 2024 11:29

The merge-base changed after approval.

@CohenArthur CohenArthur force-pushed the add-decoding-to-section-mangler branch from f7f7ab2 to 10d7826 Compare June 13, 2024 11:57
@CohenArthur
Copy link
Contributor Author

Updated the source branch once again @ghaith

@ghaith ghaith merged commit 5174c2c into PLC-lang:master Jun 13, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants