fix: Bitaccess for VAR_OUTPUT #1214
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
volsa
force-pushed
the
output-bitaccess
branch
2 times, most recently
from
a644e19 to
e139df7
Compare
volsa
commented
May 29, 2024
mhasel
reviewed
Jun 3, 2024
mhasel
reviewed
Jun 3, 2024
Comment on lines
+2833
to
+2835
| fn arguments_are_implicit(arguments: &[&AstNode]) -> bool { | ||
| !arguments.iter().any(|argument| argument.is_assignment() || argument.is_output_assignment()) | ||
| } |
mhasel
reviewed
Jun 3, 2024
Comment on lines
682
to
689
| // TODO: Can we this be simplified? | ||
| let rhs_type = { | ||
| let pou = self.index.find_pou(function_name).unwrap(); | ||
| let pou_struct = &pou.find_instance_struct_type(self.index).unwrap().information; | ||
| let DataTypeInformation::Struct { members, .. } = pou_struct else { panic!() }; | ||
|
|
||
| self.index.find_effective_type_by_name(&members[index as usize].data_type_name).unwrap() | ||
| }; |
There was a problem hiding this comment.
are all these unwraps/panics intended or are they left over from prototyping?
There was a problem hiding this comment.
Intended, because I'd argue these have to exist at codegen and otherwise expose a bug in our resolver / validator. Should I introduce a top-level comment / use expect to make it more transparent?
There was a problem hiding this comment.
I'm fine with the unwraps, I think these are just a matter of taste. I would change the panic into an unreachable if you want to convey that this branch is impossible to hit, otherwise make it a diagnostic.
…into output-bitaccess
mhasel
previously approved these changes
Jun 12, 2024
…into output-bitaccess
mhasel
approved these changes
Jun 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #1176