Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support multi-named keywords without underscore #213

Merged
merged 5 commits into from
Jul 30, 2021

Conversation

ulmer-a
Copy link
Collaborator

@ulmer-a ulmer-a commented Jul 27, 2021

Closes #207

Support multi-named keywords and log a diagnostic when encountered. The user should be encouraged to use the underscore variants by an error message similar to "found ENDFUNCTIONBLOCK, consider using END_FUNCTION_BLOCK instead".

@ulmer-a ulmer-a self-assigned this Jul 27, 2021
@codecov
Copy link

codecov bot commented Jul 27, 2021

Codecov Report

Merging #213 (1ef7314) into master (ed845d6) will increase coverage by 0.05%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #213      +/-   ##
==========================================
+ Coverage   96.70%   96.76%   +0.05%     
==========================================
  Files          41       41              
  Lines       15392    15430      +38     
==========================================
+ Hits        14885    14931      +46     
+ Misses        507      499       -8     
Impacted Files Coverage Δ
src/lexer.rs 95.32% <100.00%> (+0.38%) ⬆️
src/lexer/tests/lexer_tests.rs 98.60% <100.00%> (+0.07%) ⬆️
src/lib.rs 89.68% <100.00%> (+3.17%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ed845d6...1ef7314. Read the comment docs.

@ulmer-a ulmer-a requested a review from riederm July 28, 2021 07:47
@ulmer-a
Copy link
Collaborator Author

ulmer-a commented Jul 28, 2021

@riederm @ghaith I feel like there should be a better way to do this... However, if you haven't got any tips, this would be my approach. Actually now I think it's not event that bad...

The codecov/patch fails, because the added #[token(...)] lines. I'm not sure how to deal with this, since I already wrote a test that should cover them... recent PR fixed this

@ulmer-a ulmer-a marked this pull request as ready for review July 28, 2021 14:59
@ulmer-a ulmer-a force-pushed the multiname_keywords branch from 7a1d4fe to 9d6c579 Compare July 30, 2021 08:08
@ulmer-a ulmer-a marked this pull request as draft July 30, 2021 08:10
@ulmer-a ulmer-a removed the request for review from riederm July 30, 2021 14:05
@ulmer-a ulmer-a marked this pull request as ready for review July 30, 2021 14:38
Copy link
Collaborator

@riederm riederm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it's good 👍

@ulmer-a ulmer-a merged commit 18f4722 into PLC-lang:master Jul 30, 2021
@ulmer-a ulmer-a deleted the multiname_keywords branch August 3, 2021 09:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add support for non '_' version of multi-named keywords
2 participants