-
Notifications
You must be signed in to change notification settings - Fork 56
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Pointer and reference support #242
Conversation
Codecov Report
@@ Coverage Diff @@
## master #242 +/- ##
==========================================
+ Coverage 95.19% 95.29% +0.10%
==========================================
Files 39 40 +1
Lines 10555 10760 +205
==========================================
+ Hits 10048 10254 +206
+ Misses 507 506 -1
Continue to review full report at Codecov.
|
Add codegen and correctness tests for pointers.
@@ -221,6 +221,19 @@ impl<'a> Llvm<'a> { | |||
} | |||
} | |||
|
|||
/// create a null pointer | |||
pub fn create_null_ptr(&self) -> Result<TypeAndValue<'a>, CompileError> { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Review: I don't know how much I like this. I have no type information at this position, so I assumed i32, which does not matter since it's a null pointer.
I also returned type information on the fly, but it might make more sense to have a NULL type in the index.
|
_ improve location information _ Null now is of type VOID _ better recovery on missing TO keyword in POINTER TO ...
Closes #177
Add support for REF_TO and POINTER_TO
The types are interchangeable
TODO: