Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support case insesitive keywords #255

Merged
merged 2 commits into from
Aug 23, 2021
Merged

Support case insesitive keywords #255

merged 2 commits into from
Aug 23, 2021

Conversation

ghaith
Copy link
Collaborator

@ghaith ghaith commented Aug 21, 2021

Add support for keywords and identifiers written using different cases
Closes #246

TODO:

  • Keywords
  • Identifiers

@ghaith
Copy link
Collaborator Author

ghaith commented Aug 21, 2021

I generally don't like the way this is done atm because it is not really configurable and might be hard to extend/maintain on the long run. I don't see how else we can do it otherwise though. So I'm open to suggestions
I still like the Identifier idea in the index, which is not yet in. But the lexing seems strange here.

@codecov
Copy link

codecov bot commented Aug 21, 2021

Codecov Report

Merging #255 (65996a9) into master (7103769) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #255   +/-   ##
=======================================
  Coverage   95.19%   95.19%           
=======================================
  Files          39       39           
  Lines       10546    10555    +9     
=======================================
+ Hits        10039    10048    +9     
  Misses        507      507           
Impacted Files Coverage Δ
src/lexer.rs 95.55% <ø> (ø)
src/codegen/generators/data_type_generator.rs 93.06% <100.00%> (ø)
src/codegen/llvm_index.rs 94.96% <100.00%> (+0.12%) ⬆️
src/index.rs 94.59% <100.00%> (+0.04%) ⬆️
src/index/visitor.rs 95.94% <100.00%> (+0.03%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7103769...65996a9. Read the comment docs.

Copy link
Collaborator

@riederm riederm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good ... yes we gonna need to keep adding new keywords to these tests :-/
but I dont see any other approach with the lexer we use.

I added two additional issue to track further work

@ghaith ghaith marked this pull request as ready for review August 23, 2021 06:10
@ghaith ghaith merged commit fbbcb57 into master Aug 23, 2021
@ghaith ghaith deleted the cases branch August 23, 2021 06:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Case-insensetive language
2 participants