Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Validation constants need initializers issue294 #298

Merged
merged 2 commits into from
Sep 25, 2021

Conversation

riederm
Copy link
Collaborator

@riederm riederm commented Sep 22, 2021

add validation rules that check:

  • if all constants got initialized
  • variable-initialization can be resolved

@riederm riederm force-pushed the validation_constants_need_initializers_issue294 branch from 20d7dbe to 9c52740 Compare September 22, 2021 20:49
@codecov
Copy link

codecov bot commented Sep 22, 2021

Codecov Report

Merging #298 (e158506) into master (17653f6) will increase coverage by 0.14%.
The diff coverage is 95.45%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #298      +/-   ##
==========================================
+ Coverage   94.85%   94.99%   +0.14%     
==========================================
  Files          45       45              
  Lines       12819    12886      +67     
==========================================
+ Hits        12159    12241      +82     
+ Misses        660      645      -15     
Impacted Files Coverage Δ
src/validation.rs 89.65% <90.74%> (+8.60%) ⬆️
src/lib.rs 97.20% <100.00%> (+0.11%) ⬆️
src/validation/variable_validator.rs 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 17653f6...e158506. Read the comment docs.

@riederm riederm force-pushed the validation_constants_need_initializers_issue294 branch from 9c52740 to 1485cc0 Compare September 24, 2021 17:14
@riederm riederm requested a review from ghaith September 25, 2021 13:42
@riederm riederm linked an issue Sep 25, 2021 that may be closed by this pull request
@riederm riederm merged commit 4fa18dd into master Sep 25, 2021
@riederm riederm deleted the validation_constants_need_initializers_issue294 branch September 25, 2021 20:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Constants - constants validation - unresolvable constants
2 participants