Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Validation constants readonly constants issue293 #304

Merged
merged 6 commits into from
Sep 26, 2021
Merged

Validation constants readonly constants issue293 #304

merged 6 commits into from
Sep 26, 2021

Conversation

riederm
Copy link
Collaborator

@riederm riederm commented Sep 24, 2021

tests

  • references to constants
  • qualified referenes to constants
  • enum literals

@riederm
add validation for (const) variable initialization
1485cc0 
closes #294
@riederm
validation valid constant variable blocks
49d5011 
the CONSTANT modifier ist only valid on
VAR, VAR_EXTERNAL (not supported by this compiler yet) and
VAR_GLOBAL

closes #296
@riederm
validation for readonly constants
7ec518b 
assign statements with CONSTANTS on the left side end
in a validation-error.

tests constant references, qualified references and enum-literals

closes #293
@codecov
Copy link

codecov bot commented Sep 24, 2021 •
edited
Loading

Codecov Report

Merging #304 (77ccd02) into master (679dc1b) will increase coverage by 0.01%.
The diff coverage is 97.61%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #304      +/-   ##
==========================================
+ Coverage   95.00%   95.01%   +0.01%     
==========================================
  Files          45       45              
  Lines       12901    12928      +27     
==========================================
+ Hits        12256    12283      +27     
  Misses        645      645
Impacted Files Coverage Δ
src/codegen/generators/expression_generator.rs 88.36% <ø> (ø)
src/resolver.rs 96.22% <96.15%> (+0.06%) ⬆️
src/lib.rs 97.29% <100.00%> (+0.04%) ⬆️
src/validation/stmt_validator.rs 97.12% <100.00%> (+0.12%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 679dc1b...77ccd02. Read the comment docs.

@riederm riederm linked an issue Sep 25, 2021 that may be closed by this pull request
Constants - constants validation - constants are read only #293
Closed
@riederm riederm merged commit 5f2dbcd into master Sep 26, 2021
@riederm riederm deleted the validation_constants_readonly_constants__issue293 branch September 26, 2021 18:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ghaith ghaith ghaith approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Constants - constants validation - constants are read only
2 participants
@riederm @ghaith