Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue 348 char and wchar implement #379

Merged
merged 11 commits into from
Nov 17, 2021
Merged

Conversation

99NIMI
Copy link
Member

@99NIMI 99NIMI commented Nov 16, 2021

No description provided.

@99NIMI 99NIMI requested review from ghaith and riederm November 16, 2021 09:12
@99NIMI 99NIMI linked an issue Nov 16, 2021 that may be closed by this pull request
@codecov-commenter
Copy link

codecov-commenter commented Nov 17, 2021

Codecov Report

Merging #379 (e629523) into master (da06719) will increase coverage by 0.21%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #379      +/-   ##
==========================================
+ Coverage   92.99%   93.21%   +0.21%     
==========================================
  Files          30       30              
  Lines        9812     9968     +156     
==========================================
+ Hits         9125     9292     +167     
+ Misses        687      676      -11     
Impacted Files Coverage Δ
src/codegen/generators/expression_generator.rs 88.20% <100.00%> (+0.04%) ⬆️
src/codegen/generators/llvm.rs 87.42% <100.00%> (+2.53%) ⬆️
src/codegen/llvm_typesystem.rs 78.74% <100.00%> (+1.52%) ⬆️
src/compile_error.rs 65.38% <100.00%> (+25.70%) ⬆️
src/lib.rs 95.84% <100.00%> (+0.12%) ⬆️
src/typesystem.rs 95.45% <100.00%> (+0.23%) ⬆️
src/validation/stmt_validator.rs 97.80% <100.00%> (+0.54%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update da06719...e629523. Read the comment docs.

@99NIMI 99NIMI requested a review from ghaith November 17, 2021 09:04
ghaith
ghaith previously approved these changes Nov 17, 2021
Copy link
Collaborator

@ghaith ghaith left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@ghaith ghaith merged commit 5f30bc1 into master Nov 17, 2021
@ghaith ghaith deleted the issue-348-CHAR_and_WCHAR_implement branch November 17, 2021 13:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CHAR and WCHAR implement
3 participants