Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow multiple object files as input #419

Merged
merged 8 commits into from
Jan 6, 2022

Conversation

ghaith
Copy link
Collaborator

@ghaith ghaith commented Dec 11, 2021

Fixes #405

Moved the compile and link logic to the lib
Added a --relocatable flag to allow linking object files in an intermediate step
Created separate methods that are now testable independently.
Integration tests for the linker still missing.

@codecov-commenter
Copy link

codecov-commenter commented Dec 11, 2021

Codecov Report

Merging #419 (9eb3a38) into master (0ba48e3) will decrease coverage by 0.13%.
The diff coverage is 66.20%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #419      +/-   ##
==========================================
- Coverage   93.21%   93.08%   -0.14%     
==========================================
  Files          31       31              
  Lines       11474    11656     +182     
==========================================
+ Hits        10696    10850     +154     
- Misses        778      806      +28     
Impacted Files Coverage Δ
src/diagnostics.rs 81.74% <50.00%> (-0.83%) ⬇️
src/linker.rs 75.89% <59.09%> (+30.20%) ⬆️
src/lib.rs 85.41% <65.21%> (-12.38%) ⬇️
src/cli.rs 97.45% <90.47%> (-0.51%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0ba48e3...9eb3a38. Read the comment docs.

@ghaith ghaith requested a review from riederm December 15, 2021 10:56
@ghaith ghaith marked this pull request as ready for review December 15, 2021 10:56
@riederm riederm merged commit b90ab93 into master Jan 6, 2022
@riederm riederm deleted the issue-405-Allow_object_files_as_input_parameters branch January 6, 2022 20:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow object files as input parameters
3 participants