Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hardware address #438

Merged
merged 11 commits into from
Feb 16, 2022
Merged

Hardware address #438

merged 11 commits into from
Feb 16, 2022

Conversation

ghaith
Copy link
Collaborator

@ghaith ghaith commented Jan 19, 2022

Adds support to mark a variable as belonging to an address or a template

The generated/compiled code will not be affected, this is only available on the AST level.

Still missing: A command-line argument to output the configured hardware to be loaded/parsed in the runtime.

@ghaith ghaith force-pushed the hardware_address branch 3 times, most recently from 0a208d0 to 83b5668 Compare January 27, 2022 15:26
@ghaith ghaith force-pushed the hardware_address branch 2 times, most recently from 9d225a4 to a340b6a Compare February 2, 2022 12:11
ghaith and others added 6 commits February 9, 2022 11:06
@codecov-commenter
Copy link

codecov-commenter commented Feb 9, 2022

Codecov Report

Merging #438 (6753bd6) into master (7adbdd2) will decrease coverage by 0.25%.
The diff coverage is 89.78%.

❗ Current head 6753bd6 differs from pull request most recent head a04a126. Consider uploading reports for the commit a04a126 to get more accurate results

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #438      +/-   ##
==========================================
- Coverage   93.06%   92.80%   -0.26%     
==========================================
  Files          33       36       +3     
  Lines       12499    13205     +706     
==========================================
+ Hits        11632    12255     +623     
- Misses        867      950      +83     
Impacted Files Coverage Δ
src/index/const_expressions.rs 87.90% <0.00%> (-5.49%) ⬇️
src/tests/external_files.rs 98.03% <ø> (-0.79%) ⬇️
src/tests/multi_files.rs 100.00% <ø> (ø)
src/resolver.rs 96.52% <50.00%> (+<0.01%) ⬆️
src/lib.rs 74.33% <52.72%> (-10.97%) ⬇️
src/parser.rs 96.67% <66.66%> (-1.41%) ⬇️
src/ast.rs 92.68% <88.00%> (-0.27%) ⬇️
src/hardware_binding.rs 92.14% <92.14%> (ø)
src/lexer.rs 97.66% <93.75%> (-0.56%) ⬇️
src/index.rs 97.54% <96.15%> (+0.20%) ⬆️
... and 19 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7adbdd2...a04a126. Read the comment docs.

@ghaith ghaith marked this pull request as ready for review February 9, 2022 15:02
@ghaith ghaith requested a review from riederm February 9, 2022 15:02
Copy link
Collaborator

@riederm riederm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lets discuss my points

@ghaith ghaith requested a review from riederm February 15, 2022 10:05
@ghaith ghaith merged commit 4a7b8a6 into master Feb 16, 2022
@ghaith ghaith deleted the hardware_address branch February 16, 2022 07:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants