Support for Exponents #484
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Implement the mux builtin
If one of the types is generics (because it was builtin) it will not be cast.
Added the variadics to the index members to allow the resolver to correctly address them / modify them once a generic type needs to be replaced
The MUX, SEL and MOVE functions will have their own annotations This allows more control on the return types of the functions
The return type for builtins is now correctly annotated, the special annotation is not yet used, will be needed for EXPT
…ively only the expt does it differently
…er cases are handled by reals
Codecov Report
@@ Coverage Diff @@
## master #484 +/- ##
==========================================
+ Coverage 89.01% 89.07% +0.05%
==========================================
Files 42 42
Lines 15261 15366 +105
==========================================
+ Hits 13585 13687 +102
- Misses 1676 1679 +3
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
riederm
requested changes
Aug 8, 2022
| generics_candidates.insert("U".to_string(), vec![element_type.to_string()]); | ||
| generics_candidates.insert("V".to_string(), vec![exponant_type.to_string()]); | ||
| annotator.update_generic_call_statement(generics_candidates, "EXPT", operator, parameters, ctx) | ||
| } |
There was a problem hiding this comment.
is an else here unreachable? can we add an !impossible with explanation?
There was a problem hiding this comment.
I added an unreachable here, but I'm not sure this is the best way.
Theoratically these types exist, and if not it's the resolver's / validator's job to say so.
riederm
approved these changes
Aug 11, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds support for exponents as defined in the norm (
3**2is 3 to the power of 2)The implementation will call the appropriate EXPT function from the standard functions
It attempts to find the most efficient function for the input (int powers, or real powers)
The actual methods are implemented in the standard functions :
PLC-lang/StandardFunctions#48