354 duplicate functions should be a problem #622
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The symbolmap is an IndexMap<K, Vec<V>> that allows the index to store more than one entry for a given name. It is manually implemented (in favor of a MultiMap-Crate) because the MultiMap crates that I tested would mix the order of stuff in the index dramatically wich would: 1) create a huuuge change in .snaps that are very hard to verify 2) obfuscate the resulting IR by arbitrarily mixing the symbols (indexMap has a stable orderung)
introduced SymbolMap which is a simple yet stable (order) Multimap that would not change the huge number of snapshot-tests by changing the order of generated symbols (like the multimap crate does)
the first location is used as the primary label, the rest of the locations are treated as secondary labels.
the first location is used as the primary label, the rest of the locations are treated as secondary labels.
simplified validation code
…/github.com/PLC-lang/rusty into 354-duplicate-functions-should-be-a-problem
SourceMap moved to its own file to reduce the size of index.rs
Codecov ReportBase: 93.70% // Head: 93.78% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## master #622 +/- ##
==========================================
+ Coverage 93.70% 93.78% +0.07%
==========================================
Files 44 46 +2
Lines 16846 17460 +614
==========================================
+ Hits 15786 16374 +588
- Misses 1060 1086 +26
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
ghaith
requested changes
Oct 31, 2022
src/lib.rs
Outdated
| // ### PHASE 2 ### | ||
| // annotation & validation everything | ||
| let mut annotated_units: Vec<CompilationUnit> = Vec::new(); | ||
| let mut all_annotations = AnnotationMapImpl::default(); | ||
| let mut all_literals = StringLiterals::default(); | ||
| for (file_id, syntax_errors, unit) in all_units.into_iter() { | ||
| //todo get rid of the file_id | ||
| for (_, syntax_errors, unit) in all_units.into_iter() { |
There was a problem hiding this comment.
why not do that already? Too many changes/test changes?
There was a problem hiding this comment.
hmm ... I forgot that ... I'll give it a try
| @@ -0,0 +1,202 @@ | |||
| use crate::{ast::SourceRange, diagnostics::Diagnostic, test_utils::tests::parse_and_validate}; | |||
There was a problem hiding this comment.
Some more examples:
A global variable and a program with the same name
A global function block instance and a function of the same name
- check uniqueness of everything callable - check uniqueness of everything that can be a variable-access - check uniqueness of everything that can be used as a Type - check uniqueness of POUs added additional tests to cover corner-cases
riederm
force-pushed
the
354-duplicate-functions-should-be-a-problem
branch
from
eec5e99 to
338654c
Compare
…ould-be-a-problem
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduced SymbolMap which is a MultiMap that keeps the insertion order alive when iterating the elements. That way we keep exisiting tests working (I tried the multimap-create and it mixes up the order of stuff in the index which results in different order of elements generated in IR, so basically 80% of all tests would require a review).
Furthermore I introduced the global_validator.rs which validates stuff using the index. This commit extends Diagnostics to more than one location. first location remains the diagnostics main location, following locations are treated as secondary/see-also hints.
fixes #285
fixes #354
fixes #602