-
Notifications
You must be signed in to change notification settings - Fork 56
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
#625 sub_range check functions refactor #626
#625 sub_range check functions refactor #626
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
just got small renaming issues - I like your solution very much!
ups .... when we were looking at it, it looked like a smaller change in the tests
sry - we would have looked for an alternative if I woudl have known that you need to touch that many tests!
…b_range_typessub_range_chooses_right_implementation
Codecov ReportBase: 93.73% // Head: 93.76% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## master #626 +/- ##
==========================================
+ Coverage 93.73% 93.76% +0.02%
==========================================
Files 46 46
Lines 17530 17604 +74
==========================================
+ Hits 16432 16506 +74
Misses 1098 1098
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
…ooses_right_implementation
the call statements to the check functions are now created in the resolver
we can now annotate the call with the correct expected types