Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for parsing hardware addresses in body #651

Merged
merged 6 commits into from
Nov 15, 2022

Conversation

ghaith
Copy link
Collaborator

@ghaith ghaith commented Nov 14, 2022

Hardware Addresses (%IX1.1) can now be parsed as expressions
They get the correct type assigned to them, but the code generator will simply give them the value of 0 for now.
Fixes #621

@ghaith ghaith linked an issue Nov 14, 2022 that may be closed by this pull request
@ghaith ghaith requested a review from riederm November 14, 2022 13:10
@codecov-commenter
Copy link

codecov-commenter commented Nov 14, 2022

Codecov Report

Base: 93.79% // Head: 93.80% // Increases project coverage by +0.00% 🎉

Coverage data is based on head (2e87b4c) compared to base (d125ca4).
Patch coverage: 87.09% of modified lines in pull request are covered.

❗ Current head 2e87b4c differs from pull request most recent head 108f0e2. Consider uploading reports for the commit 108f0e2 to get more accurate results

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #651   +/-   ##
=======================================
  Coverage   93.79%   93.80%           
=======================================
  Files          46       46           
  Lines       17698    17706    +8     
=======================================
+ Hits        16600    16609    +9     
+ Misses       1098     1097    -1     
Impacted Files Coverage Δ
src/ast.rs 94.61% <ø> (+0.12%) ⬆️
src/parser.rs 96.85% <79.41%> (+0.12%) ⬆️
src/resolver.rs 97.55% <95.83%> (-0.01%) ⬇️
src/codegen/generators/expression_generator.rs 88.84% <100.00%> (+<0.01%) ⬆️
src/lexer.rs 97.56% <100.00%> (+<0.01%) ⬆️
src/parser/expressions_parser.rs 93.82% <100.00%> (-0.12%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@ghaith ghaith force-pushed the 621-channel-address-is-not-supported branch from 2e87b4c to 896da87 Compare November 14, 2022 15:29
Copy link
Collaborator

@riederm riederm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@ghaith ghaith merged commit da3da56 into master Nov 15, 2022
@ghaith ghaith deleted the 621-channel-address-is-not-supported branch November 15, 2022 15:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support for parsing the address reference anywhere in the body
3 participants