Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

670 Add debug information per file #687

Conversation

ghaith
Copy link
Collaborator

@ghaith ghaith commented Dec 9, 2022

Debug information is now added per file, and not for the entire module
This allows multiple file definitions even through the same LLVM Module

@ghaith ghaith linked an issue Dec 9, 2022 that may be closed by this pull request
@codecov-commenter
Copy link

codecov-commenter commented Dec 9, 2022

Codecov Report

Base: 94.19% // Head: 94.22% // Increases project coverage by +0.03% 🎉

Coverage data is based on head (635685d) compared to base (78a9d44).
Patch coverage: 100.00% of modified lines in pull request are covered.

❗ Current head 635685d differs from pull request most recent head 7cff906. Consider uploading reports for the commit 7cff906 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #687      +/-   ##
==========================================
+ Coverage   94.19%   94.22%   +0.03%     
==========================================
  Files          46       46              
  Lines       18785    18907     +122     
==========================================
+ Hits        17694    17816     +122     
  Misses       1091     1091              
Impacted Files Coverage Δ
src/index/symbol.rs 95.34% <ø> (ø)
src/ast.rs 96.21% <100.00%> (ø)
src/codegen.rs 99.31% <100.00%> (ø)
src/codegen/debug.rs 94.68% <100.00%> (+0.55%) ⬆️
src/codegen/generators/variable_generator.rs 94.17% <100.00%> (+0.05%) ⬆️
src/diagnostics.rs 82.39% <100.00%> (ø)
src/lib.rs 87.75% <100.00%> (+0.01%) ⬆️
src/test_utils.rs 96.93% <100.00%> (+0.01%) ⬆️
src/tests/external_files.rs 98.86% <100.00%> (+0.04%) ⬆️
src/tests/multi_files.rs 100.00% <100.00%> (ø)
... and 4 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@ghaith ghaith requested a review from riederm December 9, 2022 11:37
@ghaith ghaith merged commit a794d02 into master Dec 15, 2022
@ghaith ghaith deleted the 670-refactor-the-code-generation-so-that-it-can-produce-multiple-modules branch December 15, 2022 10:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Enable debugging for multiple files
3 participants