Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed alignment + aggregation notebooks (paper example) #14

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

LucaMarconato
Copy link
Member

@LucaMarconato LucaMarconato commented Sep 25, 2024

Fixed the alignment + aggregation notebook (same example as in the paper).

Before merging the following plot should be fixed (bug in spatialdata-plot):

Expected:
image

We get:
image

@LucaMarconato
Copy link
Member Author

I'll report the bugs in dedicated issues in spatialdata-plot, but what is broken is:

  • weird double colorbar + legend (proposed fix is 1) to name colorbar/legends so that the user knows what they refer to; 2) to let the user choose if showing the colorbar or not by a colorbar: bool argument; 3) to fix the spacing between them.
  • setting a custom cmap for a DataTree object is broken
  • in the right plot we wanted to plot the images and then plot shapes on top. The shapes are not shown.

@LucaMarconato
Copy link
Member Author

Not high priority to merge this because I plan to show this in a workshop in 3 weeks, but we should still fix the bugs in spatialdata-plot promptly as they limit usability.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant