Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid explicitly depending on Sentry by default #7

Closed
wants to merge 1 commit into from

Commits on May 25, 2023

  1. Avoid explicitly depending on Sentry by default

    As this module is more or less a plugin to Sentry proper, it seems extremely
    unlikely that this dependency is actually used - most users would probably
    already have Sentry and install sentry-auth-ldap alongside.
    
    Keeping it here, however, makes using things like Pipenv/Poetry/etc a bit
    inconvenient as the newest (>= 21.9.0) version of Sentry (plus _a lot_ of
    its subdependencies) will always end up in the lockfile - and Sentry itself
    may have come from another source, external to the package manager, such as
    the `getsentry/sentry` image from Docker Hub[^1].
    
    After this commit, it will still be possible to pull Sentry into the
    dependency tree after specifying it as an extra, e.g.:
    
    ```diff
    -sentry-auth-ldap==21.9.11
    +sentry-auth-ldap[sentry]==21.9.11
    ```
    
    [^1]: https://hub.docker.com/r/getsentry/sentry
    Asgavar committed May 25, 2023
    Configuration menu
    Copy the full SHA
    6866ba5 View commit details
    Browse the repository at this point in the history