chart now capable of displaying multiple tooltips #224
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I need to display multiple tooltips on a parallel-coordinates chart that I'm working on (http://github.com/jmcmichael/linked-scatterplots), and noticed that dimple._showBar/PointTooltip stores a single reference to a tooltip SVG group, thus limiting charts to a single tooltip.
I've updated the _showBarTooltip, _showPointTooltip, and _removeTooltip functions to store references to tooltip groups in an object indexed by d3's event key field. Multiple tooltips now work (they do in my chart, anyway - I should probably provide a simplified version as an example), and I checked several examples to ensure that the existing tooltip behavior remains preserved.