Correctly initialize min/max of boundary search #256
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If the minimum value is greater than 0, or the maximum value is less than 0, then initializing those values with 0 leads to incorrect results.
|
If I get your point right, |
|
That only works if the x axis is a time axis, which might be the case in this example, but isn’t always true in general. So using a time axis is only a workaround for a few cases. More to the point – why does the time axis not have the same problem? Because the time axis is initialized correctly: } else if (axis._hasTimeField()) {
// Parse the dates and assign the min and max
axis._min = null;
axis._max = null;
// …
var dt = axis._parseDate(d[dimension]);
if (axis._min === null || dt < axis._min) {
axis._min = dt;
}
if (axis._max === null || dt > axis._max) {
axis._max = dt;
}
// …
}The axis doesn’t start with min, max = 0, it starts with them being unset and overwrites them with the first actual min and max found in the data. This pull request suggests doing the same thing for numeric axes (except that we start with ±∞ instead). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the minimum value is greater than 0, or the maximum value is less than 0, then initializing those values with 0 leads to incorrect results.
Example:
Without this patch, X and Y axis will start at 0, squashing all the data into a tiny area of an otherwise empty chart.