Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Maintain primary key type specificity #183

Conversation

danielwestendorf
Copy link
Contributor

Partially fixes #172.

Previously schema would be dumped as such:

create_table "my_table", id: :integer, limit: 2, unsigned: true do |t|
...
end

limit and unsigned would be ignored, resulting in an incorrect representation of the schema.

After it will specify the correct Clickhouse-native type:

create_table "my_table", id: :uint8 do |t|
...
end

It does not address non-id named primary keys.

@PNixx PNixx merged commit 83675de into PNixx:master Nov 18, 2024
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Schema dumps do not support primary keys of type other than :integer/UInt32
2 participants