Having issues with 21 #161
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #161 +/- ##
========================================
Coverage 92.04% 92.04%
========================================
Files 84 84
Lines 3132 3132
========================================
Hits 2883 2883
Misses 249 249 ☔ View full report in Codecov by Sentry. |
|
It's a bit unsettling that we set this up and are having to remove different MATLAB setups under the assumption that there's something wrong outside of our control. We don't have to do this with Python as best I can tell. If you are happy, however, to consider R2021 as "deprecated," it all looks good. |
jared321
approved these changes
Sep 30, 2024
|
@jared321 If you wanted to open a PR with different matlabs tests with macOS vs ubuntu, we could consider that too |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@jared321 we are having issues with Mac+ Matlab21 on github. I think it's okay to drop. Example issues:
https://github.com/POptUS/IBCDFO/actions/runs/11109072104/job/30863553592
But I note that this PR has all green checks.