Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Using np.minimum instead of default min #162

Merged
merged 3 commits into from
Oct 24, 2024
Merged

Using np.minimum instead of default min #162

merged 3 commits into from
Oct 24, 2024

Conversation

jmlarson1
Copy link
Collaborator

When JAX was loaded, line 329 in pounders.py was causing delta to become a jax-float, which is immutable. This would cause issues later in the algorithm (e.g., dividing X by delta in formquad.py would make X immutable as well).

Copy link

codecov bot commented Oct 24, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.17%. Comparing base (fa27876) to head (ee67aaf).
Report is 5 commits behind head on develop.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop     #162   +/-   ##
========================================
  Coverage    92.17%   92.17%           
========================================
  Files           84       84           
  Lines         3143     3144    +1     
========================================
+ Hits          2897     2898    +1     
  Misses         246      246           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jmlarson1 jmlarson1 requested a review from mmenickelly October 24, 2024 16:37
@jmlarson1 jmlarson1 merged commit 3da3ae9 into develop Oct 24, 2024
55 checks passed
@jmlarson1 jmlarson1 deleted the using_npminimum branch October 24, 2024 18:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants