Dilithium: Update to NIST Draft Standard

[mkannwischer]

Manually checked properties

• Generated Github workflow (run .github/workflows/generate_workflows.py) (new schemes)
• No stringification macros
• Output-parameter pointers in functions are on the left
• Negative return values on failure of API functions (within restrictions of FO transform).
• variable declarations at the beginning (except in for (size_t i=...)
• Optional:
  • All integer types are of fixed size, using stdint.h types (including uint8_t instead of unsigned char)
  • Integers used for indexing are of size size_t

[thomwiggers]

test_functest.py seems to work on M2

[thomwiggers]

I've merged #500. This means that there are a gajillion files in conflict but should also mean that we approach green CI a bit sooner.

[mkannwischer]

I've merged #500. This means that there are a gajillion files in conflict but should also mean that we approach green CI a bit sooner.

I've rebased this on top of master. So I think it's ready for review now.
Can you test the nistkat on Apple silicon as well, please? Now it should be working fine.

[thomwiggers]

Seems to work. Just checking, like the Kyber PR, this follows the reference code repository's standard branch, right? There are some differences I believe...

[thomwiggers]

Scrolling through this looks convincing.

[mkannwischer]

Seems to work. Just checking, like the Kyber PR, this follows the reference code repository's standard branch, right? There are some differences I believe...

Yes, indeed. This version is compatible with the https://github.com/pq-crystals/dilithium/tree/standard (commit pq-crystals/dilithium@918af1a).