Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Explicitly set i_clamp_min & i_clamp_max params in default controller_configuration #242

Open
pgrice opened this issue Feb 26, 2016 · 2 comments

Comments

@pgrice
Copy link
Contributor

pgrice commented Feb 26, 2016

Currently the default arm controller gain config yaml sets only i_clamp. When the controller loads these PID gains, it uses +/- i_clamp as i_clamp_min and i_clamp_max, and sets i_clamp_min and i_clamp_max on the parameter server.

If i_clamp is subsequently changed without setting i_clamp_min and i_clamp_max explicitly, the controller loading the PID gains will read the new i_clamp value, but then overwrite min/max with the (not updated) values of i_clamp_min and i_clamp_max still on the parameter server. The result is a controller running with the incorrect i_clamp_min/max values, which can causes significant changes in behavior and stability...

It seems reasonable to me that the default parameter sets should be updated to set i_clamp_min and i_clamp_max explicitly as an example to others. This should not alter behavior on start up, but those setting different parameters by copying the yaml file will avoid the above issue.

@UltronDestroyer
Copy link
Contributor

Ahhhh, that's a small bug. Good catch

@pgrice
Copy link
Contributor Author

pgrice commented Mar 1, 2016

Created Pull Request #244 to set these explicitly. Note, the PR does not update any version numbers or changelogs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants