Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make C++ library installable #330

Closed
nachovizzo opened this issue Apr 17, 2024 · 1 comment
Closed

Make C++ library installable #330

nachovizzo opened this issue Apr 17, 2024 · 1 comment
Assignees
Labels
enhancement New feature or request

Comments

@nachovizzo
Copy link
Collaborator

          I knew this might happen sooner or later. I think the underlying problem is not the name of the targets but the lack of an installable C++ library. 

I postponed this always, but I'd say we could now fix this the proper way. Using modern cmake, and relying on exported targets instead of manually adding directories in the current build space

A probably outdated example:
https://github.com/PRBonn/vdbfusion/blob/main/src/vdbfusion/vdbfusion/cmake/Install.cmake

In summary, I think we should make the C++ library installable, like is the case with all the dependencies we use

Originally posted by @nachovizzo in #327 (comment)

@tizianoGuadagnino
Copy link
Collaborator

I will close this for my mental health, there are many other things moving for the project and I couldn't find the time to sit and just do it. I will close it for now, as we are gonna still be busy for sometimes but @nachovizzo @benemer you got my word I will come back to this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

When branches are created from issues, their pull requests are automatically linked.

2 participants