Add a link to change an author

Refs #388
PREreview · Oct 20, 2022 · 2ce26a4 · 2ce26a4
1 parent 386a508
commit 2ce26a4
Show file tree

Hide file tree

Showing 32 changed files with 71 additions and 63 deletions.
diff --git a/integration/posting-a-prereview.spec.ts b/integration/posting-a-prereview.spec.ts
@@ -459,7 +459,7 @@ test.extend(canAddAuthors)('can add other authors to the PREreview', async ({ fe
  await expect(page.locator('h1')).toHaveText('You have added 3 other authors')
  await expect(page).toHaveScreenshot()
 
- await page.goto('/preprints/doi-10.1101-2022.01.13.476201/write-a-prereview/change-author/1')
+ await page.click('role=link[name="Change Otto Lidenbrock"]')
 
  await expect(page.locator('h1')).toHaveText('Change Otto Lidenbrock')
  await expect(page).toHaveScreenshot()
@@ -1424,7 +1424,7 @@ test.extend(canAddAuthors)("have to add the changed author's name", async ({ fet
  await page.fill('role=textbox[name="Name"]', 'Otto Lidenbrock')
  await page.click('text="Save and continue"')
 
- await page.goto('/preprints/doi-10.1101-2022.01.13.476201/write-a-prereview/change-author/0')
+ await page.click('role=link[name="Change Otto Lidenbrock"]')
  await page.fill('role=textbox[name="Name"]', '')
  await page.click('text="Save and continue"')
 
@@ -1478,7 +1478,7 @@ test.extend(canAddAuthors)(
  await page.fill('role=textbox[name="Name"]', 'Otto Lidenbrock')
  await page.click('text="Save and continue"')
 
- await page.goto('/preprints/doi-10.1101-2022.01.13.476201/write-a-prereview/change-author/0')
+ await page.click('role=link[name="Change Otto Lidenbrock"]')
  await page.fill('role=textbox[name="ORCID iD (optional)"]', 'not an ORCID iD')
  await page.click('text="Save and continue"')
 

diff --git a/....ts-snapshots/can-add-other-authors-to-the-PREreview-2-Desktop-Chrome-linux.png b/....ts-snapshots/can-add-other-authors-to-the-PREreview-2-Desktop-Chrome-linux.png
diff --git a/...an-add-other-authors-to-the-PREreview-2-Desktop-Chrome-no-JavaScript--linux.png b/...an-add-other-authors-to-the-PREreview-2-Desktop-Chrome-no-JavaScript--linux.png
diff --git a/...ts-snapshots/can-add-other-authors-to-the-PREreview-2-Desktop-Firefox-linux.png b/...ts-snapshots/can-add-other-authors-to-the-PREreview-2-Desktop-Firefox-linux.png
diff --git a/...n-add-other-authors-to-the-PREreview-2-Desktop-Firefox-no-JavaScript--linux.png b/...n-add-other-authors-to-the-PREreview-2-Desktop-Firefox-no-JavaScript--linux.png
diff --git a/....spec.ts-snapshots/can-add-other-authors-to-the-PREreview-2-iPhone-11-linux.png b/....spec.ts-snapshots/can-add-other-authors-to-the-PREreview-2-iPhone-11-linux.png
diff --git a/...ots/can-add-other-authors-to-the-PREreview-2-iPhone-11-no-JavaScript--linux.png b/...ots/can-add-other-authors-to-the-PREreview-2-iPhone-11-no-JavaScript--linux.png
diff --git a/....ts-snapshots/can-add-other-authors-to-the-PREreview-3-Desktop-Chrome-linux.png b/....ts-snapshots/can-add-other-authors-to-the-PREreview-3-Desktop-Chrome-linux.png
diff --git a/...an-add-other-authors-to-the-PREreview-3-Desktop-Chrome-no-JavaScript--linux.png b/...an-add-other-authors-to-the-PREreview-3-Desktop-Chrome-no-JavaScript--linux.png
diff --git a/...ts-snapshots/can-add-other-authors-to-the-PREreview-3-Desktop-Firefox-linux.png b/...ts-snapshots/can-add-other-authors-to-the-PREreview-3-Desktop-Firefox-linux.png
diff --git a/...n-add-other-authors-to-the-PREreview-3-Desktop-Firefox-no-JavaScript--linux.png b/...n-add-other-authors-to-the-PREreview-3-Desktop-Firefox-no-JavaScript--linux.png
diff --git a/....spec.ts-snapshots/can-add-other-authors-to-the-PREreview-3-iPhone-11-linux.png b/....spec.ts-snapshots/can-add-other-authors-to-the-PREreview-3-iPhone-11-linux.png
diff --git a/...ots/can-add-other-authors-to-the-PREreview-3-iPhone-11-no-JavaScript--linux.png b/...ots/can-add-other-authors-to-the-PREreview-3-iPhone-11-no-JavaScript--linux.png
diff --git a/....ts-snapshots/can-add-other-authors-to-the-PREreview-5-Desktop-Chrome-linux.png b/....ts-snapshots/can-add-other-authors-to-the-PREreview-5-Desktop-Chrome-linux.png
diff --git a/...an-add-other-authors-to-the-PREreview-5-Desktop-Chrome-no-JavaScript--linux.png b/...an-add-other-authors-to-the-PREreview-5-Desktop-Chrome-no-JavaScript--linux.png
diff --git a/...ts-snapshots/can-add-other-authors-to-the-PREreview-5-Desktop-Firefox-linux.png b/...ts-snapshots/can-add-other-authors-to-the-PREreview-5-Desktop-Firefox-linux.png
diff --git a/...n-add-other-authors-to-the-PREreview-5-Desktop-Firefox-no-JavaScript--linux.png b/...n-add-other-authors-to-the-PREreview-5-Desktop-Firefox-no-JavaScript--linux.png
diff --git a/....spec.ts-snapshots/can-add-other-authors-to-the-PREreview-5-iPhone-11-linux.png b/....spec.ts-snapshots/can-add-other-authors-to-the-PREreview-5-iPhone-11-linux.png
diff --git a/...ots/can-add-other-authors-to-the-PREreview-5-iPhone-11-no-JavaScript--linux.png b/...ots/can-add-other-authors-to-the-PREreview-5-iPhone-11-no-JavaScript--linux.png
diff --git a/...pshots/have-to-say-if-you-need-to-add-another-author-1-Desktop-Chrome-linux.png b/...pshots/have-to-say-if-you-need-to-add-another-author-1-Desktop-Chrome-linux.png
diff --git a/...say-if-you-need-to-add-another-author-1-Desktop-Chrome-no-JavaScript--linux.png b/...say-if-you-need-to-add-another-author-1-Desktop-Chrome-no-JavaScript--linux.png
diff --git a/...shots/have-to-say-if-you-need-to-add-another-author-1-Desktop-Firefox-linux.png b/...shots/have-to-say-if-you-need-to-add-another-author-1-Desktop-Firefox-linux.png
diff --git a/...ay-if-you-need-to-add-another-author-1-Desktop-Firefox-no-JavaScript--linux.png b/...ay-if-you-need-to-add-another-author-1-Desktop-Firefox-no-JavaScript--linux.png
diff --git a/...s-snapshots/have-to-say-if-you-need-to-add-another-author-1-iPhone-11-linux.png b/...s-snapshots/have-to-say-if-you-need-to-add-another-author-1-iPhone-11-linux.png
diff --git a/...e-to-say-if-you-need-to-add-another-author-1-iPhone-11-no-JavaScript--linux.png b/...e-to-say-if-you-need-to-add-another-author-1-iPhone-11-no-JavaScript--linux.png
diff --git a/...pshots/have-to-say-if-you-need-to-add-another-author-2-Desktop-Chrome-linux.png b/...pshots/have-to-say-if-you-need-to-add-another-author-2-Desktop-Chrome-linux.png
diff --git a/...say-if-you-need-to-add-another-author-2-Desktop-Chrome-no-JavaScript--linux.png b/...say-if-you-need-to-add-another-author-2-Desktop-Chrome-no-JavaScript--linux.png
diff --git a/...shots/have-to-say-if-you-need-to-add-another-author-2-Desktop-Firefox-linux.png b/...shots/have-to-say-if-you-need-to-add-another-author-2-Desktop-Firefox-linux.png
diff --git a/...ay-if-you-need-to-add-another-author-2-Desktop-Firefox-no-JavaScript--linux.png b/...ay-if-you-need-to-add-another-author-2-Desktop-Firefox-no-JavaScript--linux.png
diff --git a/...s-snapshots/have-to-say-if-you-need-to-add-another-author-2-iPhone-11-linux.png b/...s-snapshots/have-to-say-if-you-need-to-add-another-author-2-iPhone-11-linux.png
diff --git a/...e-to-say-if-you-need-to-add-another-author-2-iPhone-11-no-JavaScript--linux.png b/...e-to-say-if-you-need-to-add-another-author-2-iPhone-11-no-JavaScript--linux.png
diff --git a/src/write-review/write-review-add-authors.ts b/src/write-review/write-review-add-authors.ts
@@ -16,6 +16,7 @@ import {
  writeReviewAddAuthorMatch,
  writeReviewAddAuthorsMatch,
  writeReviewAuthorsMatch,
+ writeReviewChangeAuthorMatch,
  writeReviewMatch,
  writeReviewRemoveAuthorMatch,
 } from '../routes'
@@ -157,6 +158,13 @@ function addAuthorsForm(preprint: Preprint, authors: ReadonlyArray<{ name: NonEm
  ({ name }, index) => html`
  <li>
  <span>${name}</span>
+ <a
+ href="${format(writeReviewChangeAuthorMatch.formatter, {
+ doi: preprint.doi,
+ index,
+ })}"
+ >Change<span class="visually-hidden"> ${name}</span></a
+ >
  <a
  href="${format(writeReviewRemoveAuthorMatch.formatter, {
  doi: preprint.doi,