Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use ESM #1750

Closed
thewilkybarkid opened this issue Jun 13, 2024 · 1 comment
Closed

Use ESM #1750

thewilkybarkid opened this issue Jun 13, 2024 · 1 comment

Comments

@thewilkybarkid
Copy link
Member

No description provided.

thewilkybarkid added a commit that referenced this issue Jun 13, 2024
@thewilkybarkid
Use an ESM-compatible runner
996928c 
This change replaces ts-node-dev with tsx.

Note that tsx can't watch arbitrary files, so changes to the local .env no longer restart the server.

Refs #1750 wclr/ts-node-dev#312, privatenumber/tsx#181
thewilkybarkid added a commit that referenced this issue Jun 13, 2024
@thewilkybarkid
Only include tsx when developing
cfc7cda 
Refs #1750, 996928c
thewilkybarkid added a commit that referenced this issue Jun 13, 2024
@thewilkybarkid
Match ESM by using file extensions
294f1f7 
Refs #1750
@thewilkybarkid thewilkybarkid mentioned this issue Jun 13, 2024
Closed
thewilkybarkid added a commit that referenced this issue Jun 13, 2024
@thewilkybarkid
Make the fp-ts ecosystem compatible with ESM
95a9ced 
Refs #1750, gcanti/fp-ts#1910 (comment)
thewilkybarkid added a commit that referenced this issue Jun 13, 2024
@thewilkybarkid
Make type re-exports compatible with ESM
16d9303 
Refs #1750
thewilkybarkid added a commit that referenced this issue Jun 13, 2024
@thewilkybarkid
Use recommended import syntax
e162744 
Refs #1750, https://github.com/redis/ioredis/tree/v5.4.1?tab=readme-ov-file#basic-usage
thewilkybarkid added a commit that referenced this issue Jun 13, 2024
@thewilkybarkid
Don't destructure objects when importing to make them ESM-compatible
1dc7540 
The types for these libraries seem to be wrong, as they don't have named exports.

Refs #1750
thewilkybarkid added a commit that referenced this issue Jun 13, 2024
@thewilkybarkid
Make instanceof compatible with ESM
b04713a 
Using instanceof doesn't work when comparing the same object but loaded through CJS and ESM.

Refs #1750
thewilkybarkid added a commit that referenced this issue Jun 13, 2024
@thewilkybarkid
Make config files compatible with ESM
e4d585e 
Refs #1750
@thewilkybarkid
Copy link
Member Author

thewilkybarkid commented Jun 14, 2024 •
edited
Loading

Remaining blockers:

thewilkybarkid added a commit that referenced this issue Jun 14, 2024
@thewilkybarkid
Make import compatible with ESM
050f756 
Refs #1750
thewilkybarkid added a commit that referenced this issue Aug 27, 2024
@thewilkybarkid
Simplify imports
65a1731 
Refs #1750
thewilkybarkid added a commit that referenced this issue Aug 27, 2024
@thewilkybarkid
Fix export orders
0bddc9f 
Refs #1750
thewilkybarkid added a commit that referenced this issue Aug 27, 2024
@thewilkybarkid
Show changes to asset files immediately, rather than having to restar…
f1c15c4 
…t the server

Refs #1750, #1886, 996928c
thewilkybarkid added a commit that referenced this issue Aug 27, 2024
@thewilkybarkid
Use a supported plugin that's compatible with import assertions
efef8d2 
After a few tests, it seems that the plugin has the same behaviour, with the bonus of ordering 'export' declarations.

Refs #1750, trivago/prettier-plugin-sort-imports#270
thewilkybarkid added a commit that referenced this issue Aug 29, 2024
@thewilkybarkid
Make the project more future-proof by using ES Modules
746caff 
There are a few changes required to get TypeScript/Node.js to work with ESM. Unfortunately, the text-clipper dependency is broken when using ESM and was replaced by a new version on a different registry, which then requires config changes for Jest and TypeScript.

Refs #1750, arendjr/text-clipper#25
thewilkybarkid added a commit that referenced this issue Aug 29, 2024
@thewilkybarkid
Fix variables
fbb28d3 
Refs #1750, https://stackoverflow.com/a/50052194
thewilkybarkid added a commit that referenced this issue Aug 29, 2024
@thewilkybarkid
Update snapshots
c515157 
Refs #1750, arendjr/text-clipper#18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@thewilkybarkid