Skip to content

Commit

Permalink
ci: fix image tag configuration
Browse files Browse the repository at this point in the history
The GitHub Actions syntax in a384f78 was incorrect, as the IMAGE_TAG variable was not interpolated and didn't exist in the Azure environment.

The Docker commands were working without interpolation, however, as the IMAGE_TAG is available in their environment.

As the deploy job passed when it should not have, I've opened Azure/webapps-deploy#189.

Refs #395
  • Loading branch information
thewilkybarkid committed Aug 10, 2021
1 parent a384f78 commit de9445f
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 2 deletions.
2 changes: 1 addition & 1 deletion .github/workflows/deploy_prereview-dev.yml
Original file line number Diff line number Diff line change
Expand Up @@ -80,5 +80,5 @@ jobs:
uses: azure/webapps-deploy@v2
with:
app-name: 'prereview-dev'
images: prereview.azurecr.io/prereview:${IMAGE_TAG}
images: prereview.azurecr.io/prereview:${{ env.IMAGE_TAG }}
configuration-file: './deploy/docker-compose-dev.yml'
2 changes: 1 addition & 1 deletion .github/workflows/deploy_prereview-staging.yml
Original file line number Diff line number Diff line change
Expand Up @@ -59,5 +59,5 @@ jobs:
with:
app-name: 'prereview2'
slot-name: 'staging'
images: prereview.azurecr.io/prereview:${IMAGE_TAG}
images: prereview.azurecr.io/prereview:${{ env.IMAGE_TAG }}
configuration-file: './deploy/docker-compose.yml'

0 comments on commit de9445f

Please sign in to comment.