Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

User controls tests #270

Merged
merged 51 commits into from
Jun 20, 2024
Merged

User controls tests #270

merged 51 commits into from
Jun 20, 2024

Conversation

MaxiLein
Copy link
Contributor

@MaxiLein MaxiLein commented Apr 29, 2024

Summary

  • Added (some) test for shortcuts (not all functionality is covered, some more shortcuts could be added)
  • Fixed some shortcuts (Select all, create Process, Copy + Paste)

This comment has been minimized.

This comment has been minimized.

@MaxiLein MaxiLein mentioned this pull request Apr 29, 2024

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

tests/ms2/process-list/process-list.spec.ts Show resolved Hide resolved
tests/process-modeler/process-modeler.page.ts Outdated Show resolved Hide resolved
await page.getByRole('main').press('Escape');
await page.getByRole('main').press('Escape');

await processModelerPage.waitForHydration();
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What is the purpose here after the shortcuts?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Using 'waitForHydration' allowed for using expect for the navigation / url change:

/* Check if back at Process-List */
    await expect(page.url(), 'Could not close modeler with shortcut (2*esc)').toMatch(
      /\/processes$/,
    );

This does not work otherwise.

The test is supposed to check for a change in the navigation, which is why I put it into an expect statement. This way a descriptive failure message is displayed in case of failure.

I changed it to:

await page.waitForURL(/\/processes$/);

But the test is not checking anything now, but rahter just applies steps.

This comment has been minimized.

1 similar comment

This comment has been minimized.

@OhKai
Copy link
Contributor

OhKai commented Jun 16, 2024

Can you resolve the merge conflicts please as well? And idk why the pipeline didn't kick off for your last commit.

This comment has been minimized.

Copy link

CLOUDRUN ACTIONS

✅ Successfully created Preview Deployment.

https://pr-270---ms-server-staging-c4f6qdpj7q-ew.a.run.app

@OhKai OhKai merged commit e29c2fd into main Jun 20, 2024
11 checks passed
@OhKai OhKai deleted the user-controls-tests branch June 20, 2024 00:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants