-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
User controls tests #270
User controls tests #270
Conversation
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
await page.getByRole('main').press('Escape'); | ||
await page.getByRole('main').press('Escape'); | ||
|
||
await processModelerPage.waitForHydration(); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What is the purpose here after the shortcuts?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Using 'waitForHydration' allowed for using expect for the navigation / url change:
/* Check if back at Process-List */
await expect(page.url(), 'Could not close modeler with shortcut (2*esc)').toMatch(
/\/processes$/,
);
This does not work otherwise.
The test is supposed to check for a change in the navigation, which is why I put it into an expect statement. This way a descriptive failure message is displayed in case of failure.
I changed it to:
await page.waitForURL(/\/processes$/);
But the test is not checking anything now, but rahter just applies steps.
This comment has been minimized.
This comment has been minimized.
1 similar comment
This comment has been minimized.
This comment has been minimized.
Can you resolve the merge conflicts please as well? And idk why the pipeline didn't kick off for your last commit. |
This comment has been minimized.
This comment has been minimized.
✅ Successfully created Preview Deployment. |
Summary