Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adjustable List-Column-Width #278

Merged
merged 6 commits into from
May 15, 2024
Merged

Adjustable List-Column-Width #278

merged 6 commits into from
May 15, 2024

Conversation

MaxiLein
Copy link
Contributor

@MaxiLein MaxiLein commented May 14, 2024

Summary

Details

/* Add functionality for changing width of columns */
  const columns = [...] /* List of ant design columns */
  columnsWithResize = useColumnWidth(
    columns, /* Just pass the columns*/
    'columns-in-table-view-process-list', /* key for the list in the user-preferences -> currently non-optional, maybe that could be changed (?)*/
    [ 'Favorites', ] /* values of the 'key' value of each column, that should not be resizeable */
);

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

Copy link

CLOUDRUN ACTIONS

✅ Successfully created Preview Deployment.

https://pr-278---ms-server-staging-c4f6qdpj7q-ew.a.run.app

Copy link
Contributor

@OhKai OhKai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fyi the problems with the tests were:

  1. The way to open a process in the list is done by clicking on the table row. Playwright executes that in the center of an element, but that wasn't a link, because the description is a <span> and didn't fill the whole width.
  2. The single process export button didn't work, because clicking the button no longer auto-selects the row. I added that back in, because I think it is good visual feedback for the user as well.

@OhKai OhKai merged commit 06deb48 into main May 15, 2024
11 checks passed
@OhKai OhKai deleted the list-update branch May 15, 2024 16:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants