Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ms2/share modal improvements #437

Open
wants to merge 6 commits into
base: main
Choose a base branch
from

Conversation

FelipeTrost
Copy link
Contributor

Summary

I only managed to implement the changes for the link share modal described in #259.
I also fixed some bugs along the way.

Details

  • Process page throws UnauthorizedError -> correct error message on client
  • fix for legacy-store: parse dates of processes, which were being stored as strings and needed to be parsed again after reading them.
  • process-documentation: The function called in the effect was mutating the state array and then calling setState with that array, since the array is still the same array (pointer), no rerender was triggered. This cause a part of the ducmentation to be missing until you triggered another rerender somehow (by resizing the screen for example).
  • documentation-page: creatorId is not defined on legacy store, so I just used optional chaining to avoid the error.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant