Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
Implements a detailed score-viewing feature by making list titles optional, adding a score modal and associated data fetching, and integrating the modal into the member information UI.
- Made
Listcomponent’stitleprop optional and updated rendering behavior. - Created
ScoreModalcomponent,useGetScorehook, and API call to fetch scores. - Integrated modal open/close logic into
InformationUI and wired up modal display.
Reviewed Changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| packages/shared/src/list.tsx | Made title optional and defaulted missing title |
| apps/admin/src/widgets/member/ui/information.tsx | Added modal state, handlers, and modal integration |
| apps/admin/src/entities/member/ui/scoreModal.tsx | Implemented score modal with data fetching |
| apps/admin/src/entities/member/model/useGetScore.ts | Added React Query hook to fetch scores |
| apps/admin/src/entities/member/model/score.ts | Defined score-related interfaces |
| apps/admin/src/entities/member/api/getScore.ts | Implemented API call with error handling |
Comments suppressed due to low confidence (2)
apps/admin/src/entities/member/ui/scoreModal.tsx:1
- No tests cover the
ScoreModalcomponent; consider adding unit or integration tests to validate modal rendering and data fetching behaviors.
"use client";
apps/admin/src/widgets/member/ui/information.tsx:57
- [nitpick] Slicing the ID starting at index 1 removes the first character of the username; verify this is intentional or adjust the slice range to include the full identifier.
id={student?.email?.split("@")[0]?.slice(1) as string}
|
✅ CI success |
|
✅ CI success |
Dino0204
approved these changes
Jul 6, 2025
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
|
✅ CI success |
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
|
✅ CI success |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📝작업 내용