Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Playground can't build on npm@9 #1296

Closed
max-sixty opened this issue Dec 19, 2022 · 2 comments · Fixed by #1302
Closed

Playground can't build on npm@9 #1296

max-sixty opened this issue Dec 19, 2022 · 2 comments · Fixed by #1302

Comments

@max-sixty
Copy link
Member

I can't work out why...

$ npm install -g npm@9

$ npm run build

> prql-playground@0.1.0 build
> react-scripts build

Creating an optimized production build...
Failed to compile.

Module not found: Error: Can't resolve 'prql-js/dist/bundler' in '/Users/maximilian/workspace/prql/playground/src/workbench'

I'll lock the npm version at 8 for the moment in #1293, as I'm probably not being that productive attempting to fix it.

@Shuozeli
Copy link
Contributor

Seems to be related to npm/cli#5965. The default value of install-links is set to true in npm@9.

Install the ../prql-js with install-links as false.

npm i ../prql-js --install-links=false
npm run build

max-sixty added a commit that referenced this issue Dec 20, 2022
Closes #1296

Thanks to @Shuozeli for finding the solution!
@max-sixty
Copy link
Member Author

Great find @Shuozeli !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants