-
Notifications
You must be signed in to change notification settings - Fork 222
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Omit table name when only one ident in SELECT #1094
Conversation
40a1360
to
a0234a2
Compare
a0234a2
to
64cfd77
Compare
64cfd77
to
aa093c6
Compare
This is good; I think providing more concise SQL is important and this contributes for small queries. I was trying to think if it would handle queries with multiple stages, like: from employees
take 5
group [name] (
aggregate [sum salary]
) On WITH table_0 AS (
SELECT
employees.* # would this be `*`?
FROM
employees
LIMIT
5
)
SELECT
name,
SUM(salary)
FROM
table_0
GROUP BY
name Unfortunately If it doesn't yet, no stress, though maybe we add a comment in the code. I'll let @aljazerzen take a glance too. Thanks @MarinPostma ! |
@max-sixty I think it does. This:
compiles to:
#1096 fixes the aliasing issue |
Excellent! Feel free to merge if you're confident overall (easy to revert if @aljazerzen spots something) |
This is great! I dont even have any suggestions! |
fixes #1081