feat: Make s-string select req case insensitive #1444
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ELECT case insensitive.
max-sixty
approved these changes
Jan 6, 2023
There was a problem hiding this comment.
Great! Thanks a lot @BlurrechDev
If you're up for adding an entry in changelog as a follow-up, then great, otherwise I can add one when I do a release.
(BTW no need to close the previous one and reopen a new one, it's always fine to push more commits. But zero stress!)
| locks: vec![], | ||
| }) | ||
|
|
||
| let prefix = if let Some(string) = string.trim().get(0..7) { |
There was a problem hiding this comment.
Yeah, I think we probably do need this 0..7 here, even though it's a bit awkward. The alternative would be upper case the whole string and feed it into the existing function, but this is more than fine.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Attempts to close #1439
Uses eq_ignore_ascii_case to confirm the prefix is correct.
Adds two tests for "select" and "sElEcT". (We have plenty of "SELECT" coverage already.)
Very new to Rust so if anything I do is contrived please let me know so I can learn 👍
Take 2 with formatting corrected.