Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: ensure use chumsky 0.9.2 or later #2110

Merged
merged 3 commits into from
Mar 11, 2023
Merged

Conversation

eitsupi
Copy link
Member

@eitsupi eitsupi commented Mar 11, 2023

Fix #2103 (Follow up #2002)

@max-sixty
Copy link
Member

Ah ha! Sorry, so this was on prql-compiler.


Possibly we should add https://crates.io/crates/cargo-minimal-versions to CI?

I just tried running it, it failed, but we hit duckdb/duckdb-rs#134 before finding this problem, so we'll have to wait for that before turning it on.

@max-sixty max-sixty merged commit 12a488a into PRQL:main Mar 11, 2023
@eitsupi eitsupi deleted the bump-chumsky branch March 11, 2023 23:34
@eitsupi
Copy link
Member Author

eitsupi commented Mar 11, 2023

Possibly we should add crates.io/crates/cargo-minimal-versions to CI?

I just tried running it, it failed, but we hit wangfenjin/duckdb-rs#134 before finding this problem, so we'll have to wait for that before turning it on.

I didn't know about it, but looks great!
Thank you for working on that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Multiple error messages do not work in prqlr (R)
2 participants