ci: build prqlc on PRs #2568
ci: build prqlc on PRs #2568
Conversation
|
It seems working. |
eitsupi
force-pushed
the
upload-prqlc
branch
2 times, most recently
from
fa3dcb2 to
21a1cc2
Compare
This comment was marked as outdated.
This comment was marked as outdated.
There was a problem hiding this comment.
Excellent!! Thanks a lot.
A couple of points:
-
No stress about Linux arm64. I see some comments in Cannot cross-compile aarch64-musl on x86_64 linux rust-lang/rust#46651 (comment), not sure if they would help, but fine to leave for another day.
- I've also heard about https://github.com/cross-rs/cross, but don't have any experience with it. To the extent this can encapsulate much of the complication around non-default targets, that could work well. I don't see obvious docs for how to use with GHA — not sure whether that's because it's so easy or so difficult! :)
-
I'm not sure whether this necessarily needs to be an "action" rather than a normal workflow, especially now that GH has loosened the restrictions on workflows calling other workflows. But it's also fine as an action.
-
Do you know what we'd have to do to get these publishing on each release? We may have to auto-release IIUC. That would be a nice use of this.
| @@ -108,3 +108,27 @@ jobs: | |||
| allowed-failures: check-links | |||
| allowed-skips: test-all, publish-web, nightly | |||
| jobs: ${{ toJSON(needs) }} | |||
|
|
|||
| build-prqlc: | |||
There was a problem hiding this comment.
Before merging, I think probably we have this in test-all rather than pull-request — or are there times it would fail on new code that we'd want to know about?
There was a problem hiding this comment.
My idea was to provide an easy way to try out features added by pull requests.
For example, I believe duckdb builds and uploads duckdb CLI executables with every pull request.
There was a problem hiding this comment.
OK great, we can try it.
I do notice our CI queue filling up occasionally, and this would almost double the number of jobs. So if it becomes an issue we could always add a pr-build-artifacts label and run it based on that.
Definitely fine to try, I agree that would be a nice thing to have access to.
Co-authored-by: Maximilian Roos <5635139+max-sixty@users.noreply.github.com>
for more information, see https://pre-commit.ci
|
Thank you for reviewing this. I considered cross, but did not try it at this time due to the need for a completely different workflow to use Docker and concerns about slowdowns due to QEMU emulation. Attaching these to the release would be easy as it is just one (?) additional step. |
|
Thanks to the advice I received in rust-lang/stacker#80, I am now able to build for Linux arm64.
Once this PR is merged I will work on attaching these to the releases. |
Addresses #1910