Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: Consolidate regex ident checks #2678

Merged
merged 1 commit into from
Jun 1, 2023
Merged

refactor: Consolidate regex ident checks #2678

merged 1 commit into from
Jun 1, 2023

Conversation

max-sixty
Copy link
Member

From #2669 (comment)

The behavior change is on handling *, which I think is correct — at least it seems to compile OK.

@max-sixty
refactor: Consolidate regex ident checks
8c08cc6 
From PRQL#2669 (comment)

The behavior change is on handling `*`, which I _think_ is correct — at least it seems to compile OK.
@max-sixty max-sixty mentioned this pull request Jun 1, 2023
Merged
aljazerzen
aljazerzen reviewed Jun 1, 2023
View reviewed changes
Copy link
Member

@aljazerzen aljazerzen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I trust you that this is correct.

@max-sixty
Copy link
Member Author

I trust you that this is correct.

TBC when I say "I think is correct", I mean that this is the correct PRQL: https://github.com/PRQL/prql/pull/2678/files#diff-5557efedcdc69e2fbea057c573b9fb68fb96c2f5b8a087b0ba8b25531bfd949dR9-R10 — i.e. that we should not be quoting * like we do now.

@aljazerzen
Copy link
Member

Oh, no that is not correct.

Well, produced PRQL will still be correct, but the backticks are not required in a.`*`.

@max-sixty
Copy link
Member Author

Oh, no that is not correct.

Well, produced PRQL will still be correct, but the backticks are not required in a.`*`.

Sorry — to confirm — is the proposed code correct or the existing code?

I think the proposed code is correct, which removes the backticks — right?

@max-sixty max-sixty merged commit d257aa4 into PRQL:main Jun 1, 2023
@max-sixty max-sixty deleted the regex branch June 1, 2023 19:48
@aljazerzen
Copy link
Member

I'm embarrassed how many times I've made a mistake here. Yes, removing backticks is correct.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aljazerzen aljazerzen aljazerzen left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@max-sixty @aljazerzen