Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: Update to Node20 actions #4571

Merged
merged 3 commits into from
Jun 9, 2024
Merged

Conversation

richb-hanover
Copy link
Contributor

Rather than use my richb-hanover/cargo (which will forever lag the proper versions), switch to clechasseur/rs-cargo which seems to be in active maintenance. This clears up the lion's share of "Node 16 is deprecated..." warnings during builds.

@clechasseur was also kind enough to update rustsec/audit-check@v1 to use Node 20 (it's v1.4.1 now). However, it appears that the upstream hasn't published that new action. There's an Issue in the repo requesting this.

Once that's complete, it looks as if all the warnings during nightly builds will have been eliminated.

@richb-hanover richb-hanover changed the title Update to Node20 actions dev: Update to Node20 actions Jun 9, 2024
@richb-hanover richb-hanover changed the title dev: Update to Node20 actions ci: Update to Node20 actions Jun 9, 2024
@max-sixty
Copy link
Member

Super, thanks a lot @richb-hanover !

@max-sixty max-sixty enabled auto-merge (squash) June 9, 2024 20:49
@max-sixty max-sixty merged commit dfd9c52 into PRQL:main Jun 9, 2024
85 of 86 checks passed
@richb-hanover richb-hanover deleted the node20-actions branch June 11, 2024 11:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants