Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bisect to output results incrementally #174

Closed
mikebentley15 opened this issue Jul 17, 2018 · 2 comments
Closed

Bisect to output results incrementally #174

mikebentley15 opened this issue Jul 17, 2018 · 2 comments
Assignees
@IanBriggs
Labels
enhancement good first issue A good place to start python Involves touching python code

Comments

@mikebentley15
Copy link
Collaborator

Currently, you must wait for bisect to finish searching (either file bisect or symbol bisect) in order to see what it found. In reality, bisect is identifying one file or symbol at a time and setting it aside. I would like to incrementally output the result to the console so that if the user needs to exit early, they would have partial results rather than nothing.
@mikebentley15 mikebentley15 added enhancement good first issue A good place to start python Involves touching python code labels Jul 17, 2018
@mikebentley15
Copy link
Collaborator Author

This could be done with an optional argument called found_callback, which is a callback function to call whenever another blamed element is found. It would default to None. I think this is a good approach.

@IanBriggs IanBriggs self-assigned this Jul 17, 2018
mikebentley15 added a commit that referenced this issue Jul 20, 2018
@mikebentley15
Merge pull request #179 from PRUNERS/issue174-incremental-output
50f54a1 
Issue174 incremental output, fixes #174
@mikebentley15
Copy link
Collaborator Author

Fixed in pull request #179

@mikebentley15 mikebentley15 mentioned this issue Apr 9, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@IanBriggs IanBriggs

Labels
enhancement good first issue A good place to start python Involves touching python code
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@IanBriggs @mikebentley15