Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MPI support: does not work with MPICH #222

Closed
mikebentley15 opened this issue Sep 15, 2018 · 2 comments · Fixed by #264
Closed

MPI support: does not work with MPICH #222

mikebentley15 opened this issue Sep 15, 2018 · 2 comments · Fixed by #264
Assignees
Labels
bug documentation Involves touching documentation make Involves touching GNU Makefiles python Involves touching python code

Comments

@mikebentley15
Copy link
Collaborator

Bug Report

Description of the problem
The MPI support was developed against OpenMPI, but the mpic++ command from OpenMPI has different flags than the one from MPICH. When trying to run FLiT under MPICH, it fails immediately.

Suggested fix
In Makefile.in, either do a check to see what kind of mpi we are using and change the flag accordingly, or just try both sets of flags, allowing the backup set to be used if the primary fails to function correctly.

This allows swapping out the implementations of MPI by just changing your path to point to mpirun and mpic++ from the MPI runtime you desire.

Alternative approaches

  • Check for the type of MPI runtime from flit_update.py when generating the Makefile
  • Add a mpi_type field in flit-config.toml

There may be other approaches not thought of or discussed in this bug report

@mikebentley15 mikebentley15 added bug python Involves touching python code make Involves touching GNU Makefiles documentation Involves touching documentation labels Sep 15, 2018
@mikebentley15 mikebentley15 self-assigned this Sep 15, 2018
@mikebentley15
Copy link
Collaborator Author

Looks like Intel's version of MPI is similar to MPICH. That means it is likely that when we get support for MPICH fully functional, we may also get it working with Intel MPI for free.

@mikebentley15
Copy link
Collaborator Author

We think MVAPICH has the same interface as MPICH, so they can both be fixed by this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug documentation Involves touching documentation make Involves touching GNU Makefiles python Involves touching python code
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant